Skip to content

Fail if I/O error occurs during testing #72089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2020
Merged

Fail if I/O error occurs during testing #72089

merged 1 commit into from
May 11, 2020

Conversation

Mark-Simulacrum
Copy link
Member

First known case of this is in #72053 (comment) but may have happened before then.

r? @pietroalbini

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors rollup=never in case we're silently accepting this somehow on CI; if so we'll need a more complicated fix

@pietroalbini
Copy link
Member

@bors r+ p=100

@bors
Copy link
Collaborator

bors commented May 11, 2020

📌 Commit a5ba752 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2020
@bors
Copy link
Collaborator

bors commented May 11, 2020

⌛ Testing commit a5ba752 with merge 1847bb88796e9f2a760095938f07bcf4db12212e...

@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 11, 2020
@pietroalbini
Copy link
Member

Nominating for this change to be backported to beta, as it fixed a really bad bug in our test harness.

@bors
Copy link
Collaborator

bors commented May 11, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 1847bb88796e9f2a760095938f07bcf4db12212e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2020
@bors
Copy link
Collaborator

bors commented May 11, 2020

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@pietroalbini
Copy link
Member

What.

@bors retry

@bors
Copy link
Collaborator

bors commented May 11, 2020

⌛ Testing commit a5ba752 with merge 81bc86984d5bf63c09d43ec7db6cc0e7b0dc5949...

@bors
Copy link
Collaborator

bors commented May 11, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2020
@Mark-Simulacrum
Copy link
Member Author 


2020-05-11T15:52:06.0464770Z thread '<unnamed>' panicked at 'attempt to subtract with overflow', C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\rustc-rayon-core-0.3.0\src\sleep\mod.rs:330:21
2020-05-11T15:52:06.0465251Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-05-11T15:52:06.0465421Z Rayon: detected unexpected panic; aborting

What?!

@bors retry -- shouldn't be related to this

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2020
@bors
Copy link
Collaborator

bors commented May 11, 2020

⌛ Testing commit a5ba752 with merge 99cb9cc...

@bors
Copy link
Collaborator

bors commented May 11, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 99cb9cc to master...

@bors bors merged commit 99cb9cc into rust-lang:master May 11, 2020
@Mark-Simulacrum Mark-Simulacrum deleted the error-is-really-an-error branch May 13, 2020 14:07
@pietroalbini
Copy link
Member

@rustbot modify labels: beta-accepted

Discussed this in the infra team meeting, accepting for backport.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 13, 2020
@Elinvynia Elinvynia mentioned this pull request May 22, 2020
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2020
@bors
Auto merge of rust-lang#72468 - Elinvynia:backport, r=Mark-Simulacrum
02c25b3 
[beta] Rollup backports

This includes:
* Fail if I/O error occurs during testing rust-lang#72089
* Fix hang in lexical_region_resolve rust-lang#72087
* Fix E0284 to not use incorrect wording rust-lang#71960
* Bump pulldown-cmark rust-lang#71682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @pietroalbini @bors @rust-highfive @rustbot